Swift-driver integration, Part II: add Swift front-end parsing stage#209
Merged
polac24 merged 4 commits intospotify:masterfrom Jun 1, 2023
Merged
Swift-driver integration, Part II: add Swift front-end parsing stage#209polac24 merged 4 commits intospotify:masterfrom
polac24 merged 4 commits intospotify:masterfrom
Conversation
polac24
force-pushed
the
add-driver-parsing
branch
from
d491cb5 to
338cbd1
Compare
polac24
commented
May 31, 2023
| file: primaryInputFilesURLs[i], | ||
| dependencies: dependenciesPaths.get(i).map(URL.init(fileURLWithPath:)), | ||
| object: outputPaths.get(i).map(URL.init(fileURLWithPath:)), | ||
| // for now - swift-dependencies are not requested in the driver compilation mode |
Collaborator
Author
There was a problem hiding this comment.
at least I have never seen that
| } | ||
|
|
||
| override public func run() throws { | ||
| // TODO: implement in a follow-up PR |
Collaborator
Author
There was a problem hiding this comment.
This will be added separately to keep this PR small(er)
|
|
||
| func run(criticalSection: () throws -> Void) throws { | ||
| // TODO: implement synchronization in a separate PR | ||
| try criticalSection() |
Collaborator
Author
There was a problem hiding this comment.
This will be added separately to keep this PR small(er)
polac24
changed the title
polac24
requested review from
CognitiveDisson,
PatrikBillgren,
acbdev and
aleksandergrzyb
aleksandergrzyb
previously approved these changes
May 31, 2023
| let customRewriteEnvs: [String]? | ||
| let irrelevantDependenciesPaths: [String]? | ||
| let gracefullyHandleMissingCommonSha: Bool? | ||
| let enableSwifDriverIntegration: Bool? |
Contributor
There was a problem hiding this comment.
Suggested change
| let enableSwifDriverIntegration: Bool? | |
| let enableSwiftDriverIntegration: Bool? |
| // -target is required | ||
| case emitMissingTarget | ||
| // -moduleName is required | ||
| case emiMissingModuleName |
Contributor
There was a problem hiding this comment.
Suggested change
| case emiMissingModuleName | |
| case emitMissingModuleName |
aleksandergrzyb
approved these changes
Jun 1, 2023
This was referenced Jun 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part II (out of IV) of the swift driver integration:
xcswift-frontendwrapper that parses input parameters and stores them into the structured module (struct)enable_swift_driver_integrationconfig that will enable the driver integrationXCSwiftFrontendandSwiftFrontendOrchestratorthat are no-op for now, but in a follow-up PR will add swift-frontend processes synchronizationPrevious PR: #208